Issue #88: Improve error message for better debugging.

Signed-off-by: Shishir Mahajan <[email protected]>
containers · Oct 2, 2020 · 99e2053 · 99e2053
1 parent 933ce38
commit 99e2053
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/driver.go b/driver.go
@@ -82,7 +82,7 @@ func (l *lvmDriver) Create(req *volume.CreateRequest) error {
 			return fmt.Errorf("Please don't specify --opt keyfile= for snapshots")
 		}
 		if isThinSnap, _, err = isThinlyProvisioned(vgName, snap); err != nil {
-			l.logger.Err(fmt.Sprintf("Create: lvdisplayGrep error: %s", err))
+			l.logger.Err(fmt.Sprintf("Create: lvdisplayGrep error: %v", err))
 			return fmt.Errorf("Error creating volume")
 		}
 	}
@@ -237,6 +237,7 @@ func (l *lvmDriver) Get(req *volume.GetRequest) (*volume.GetResponse, error) {
 
 	createdAt, err := getVolumeCreationDateTime(v.VgName, v.Name)
 	if err != nil {
+		l.logger.Err(fmt.Sprintf("Get: %v", err))
 		return nil, err
 	}
 

diff --git a/utils.go b/utils.go
@@ -107,7 +107,7 @@ func loadFromDisk(l *lvmDriver) error {
 func lvdisplayGrep(vgName, lvName, keyword string) (bool, string, error) {
 	outByttes, err := exec.Command("lvdisplay", fmt.Sprintf("/dev/%s/%s", vgName, lvName)).Output()
 	if err != nil {
-		return false, "", err
+		return false, "", fmt.Errorf("Error in lvdisplay. This usually happens if one of the underlying lvm volumes is missing or deleted: %v", err)
 	}
 	var result []string
 	outStr := strings.TrimSpace(string(outByttes[:]))