move unshare into chdir #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Burning1020 @fuweid Thanks for suggestion. |
fuweid
reviewed
May 31, 2024
zzzzzzzzzy9
force-pushed
the
pull-branch
branch
11 times, most recently
from
e239630
to
87e134e
Compare
fuweid
reviewed
Jul 1, 2024
| let fs_type = Some("overlay"); | ||
| let source = Some("overlay"); | ||
| let workdir = | ||
| "/var/lib/containerd-test/io.containerd.snapshotter.v1.overlayfs/snapshots/0/work"; |
There was a problem hiding this comment.
To be honest, I don't think it's good idea to create test folder like this. Please use /tmp/$RANDOM-LONG-STRING. Thanks.
fuweid
reviewed
Jul 1, 2024
| let target = "/run/containerd/io.containerd.runtime.v2.task/k8s.io/mount-test/rootfs"; | ||
| std::fs::create_dir_all(target).unwrap(); | ||
| let current_dir = env::current_dir().unwrap(); | ||
| std::thread::spawn(move || mount_rootfs(fs_type, source, &options, target).unwrap()); |
There was a problem hiding this comment.
Why must it spawn thread to mount it?
There was a problem hiding this comment.
because this mount_rootfs is called in a new thread by tokio::spawn_blocking, so I think it's better to test mount_rootfs in a spawn thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need clone if we don't need to change current dir.