Added removal of "v" on handler

[EStork09]

To align with the format of the manifests map (removes the v) and to address #17.

The prepareChart removes the "v" if it is on the chart version resulting in the manifest target keys to be without the "v".
Removing the v from the target variable seems to be fine, you seem to be able to use with the helm client either interchangeable after this change/with the repo itself by default. i.e.:

helm pull jetstack/cert-manager --version 1.15.3 == helm pull jetstack/cert-manager --version v1.15.3

I am not entirely sure if this will have any other impact, but so far this appears to address the issue mentioned previously.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of version identifiers by refining the processing of the target variable.
  • Ensured compatibility with version strings that start with "v".

[coderabbitai]

Walkthrough

The change introduces a conditional check in the Handle method of the Manifests struct located in internal/manifest/manifest.go. It modifies the processing of the target variable by ensuring that if target is not empty and begins with "v", the leading "v" is removed. This adjustment refines how version identifiers are handled within the method while maintaining the overall control flow.

Changes

File Path	Change Summary
internal/manifest/manifest.go	Added a conditional check in the Handle method to remove the leading "v" from the target variable if it is not empty and starts with "v".

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Manifests

    Client->>Manifests: Call Handle(target)
    Manifests-->>Client: Process target
    alt target starts with "v"
        Manifests->>Manifests: Remove leading "v"
    end
    Manifests-->>Client: Return processed target

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 81b6020 and e1deac0.

Files selected for processing (1)

• internal/manifest/manifest.go (1 hunks)

Additional comments not posted (1)

internal/manifest/manifest.go (1)

116-118: Verify the impact of removing the "v" prefix.

The change aligns with the PR objective of removing the "v" prefix from chart versions to format the manifests map consistently. However, it's crucial to ensure that this modification does not break any existing functionality or cause unexpected behavior in the codebase.

Please run the following script to search for potential occurrences where the "v" prefix is expected or relied upon:

Verification successful

---

Removal of "v" prefix is consistent and localized

The change to remove the "v" prefix from the target string in manifest.go is verified to be consistent with the existing code in the manifest package. The analysis of charts.go reveals a similar approach to handling version prefixes, indicating a standardized practice within the package.

Key findings:

• No direct dependencies between manifest.go and charts.go are affected by this change.
• The manifest package appears to be designed to work flexibly with or without the "v" prefix.
• The change is localized to the manifest package and doesn't introduce conflicts or inconsistencies.

This modification aligns with the PR objective and maintains consistency within the package.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for potential occurrences where the "v" prefix is expected or relied upon.

# Test 1: Search for string comparisons or manipulations involving the "v" prefix.
rg --type go $'"v" \+ .+' -g '!manifest.go'
rg --type go $'.+ \+ "v"' -g '!manifest.go' 
rg --type go $'strings\.HasPrefix\(.+, "v"\)' -g '!manifest.go'
rg --type go $'strings\.TrimPrefix\(.+, "v"\)' -g '!manifest.go'

# Test 2: Search for parsing or validation logic that expects the "v" prefix.
rg --type go $'strings\.TrimPrefix\(.+, "v"\)' -g '!manifest.go'
rg --type go $'if .+ == "v.+" \{' -g '!manifest.go'

# Expected results: The script should return no concerning occurrences of the "v" prefix being relied upon outside of manifest.go.
# If any relevant occurrences are found, further investigation and potential adjustments may be necessary to ensure compatibility.

Length of output: 593

---

Script:

#!/bin/bash
# Description: Analyze the relationship between manifest.go and charts.go

# Display the content of charts.go
echo "Content of internal/manifest/charts.go:"
cat internal/manifest/charts.go

echo "\n--- Searching for imports or usage of manifest.go functions in charts.go ---"
# Search for imports from manifest
grep -n "import" internal/manifest/charts.go

# Search for function calls that might be from manifest.go
grep -n "manifest\." internal/manifest/charts.go

# Search for any references to 'target' variable (which is modified in manifest.go)
grep -n "target" internal/manifest/charts.go

Length of output: 6832

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Vad1mo]

@EStork09, can you please describe the behavior in the README!