Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new survey analysis recipe #1440

Closed
wants to merge 4 commits into from
Closed

new survey analysis recipe #1440

wants to merge 4 commits into from

Conversation

danicafine
Copy link
Contributor

@danicafine danicafine commented Nov 5, 2022 •
edited
Loading

Moving to #1447 as requested.

@danicafine danicafine requested a review from a team as a code owner November 5, 2022 00:23
davetroiano
davetroiano requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@davetroiano davetroiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the recipe! just needs a few fixes mostly around the test

also, could you do this PR as a branch directly off of the confluentinc repo rather than from a fork? the automated Semaphore build doesn't get run on PRs from forks

.semaphore/semaphore.yml Show resolved Hide resolved
_data/harnesses/survey-responses/ksql-test.yml Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql-test/code/Makefile Outdated Show resolved Hide resolved
...als/survey-responses/ksql-test/code/tutorial-steps/test/expected-outputs/survey_analysis.log Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql/markup/dev/ksqlDB.adoc Outdated Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql/markup/dev/ksqlDB.adoc Outdated Show resolved Hide resolved
bbejeck
bbejeck reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tutorial @danicafine - I just have a couple of minor comments this LGTM modulo comments from @davetroiano

_includes/tutorials/survey-responses/ksql/code/tutorial-steps/dev/source.json Outdated Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql/code/tutorial-steps/dev/source.json Outdated Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql/code/tutorial-steps/dev/source.sql Outdated Show resolved Hide resolved
_includes/tutorials/survey-responses/ksql/code/tutorial-steps/dev/source.sql Outdated Show resolved Hide resolved
@danicafine danicafine mentioned this pull request Nov 7, 2022
Merged
9 tasks
@danicafine danicafine closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbejeck bbejeck bbejeck left review comments

@davetroiano davetroiano davetroiano requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicafine @bbejeck @davetroiano