Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query.parameters configuration parameter #1307

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ITman1
Copy link

@ITman1 ITman1 commented Feb 2, 2023

Problem

We were unable to customize automatically generated SELECT in timestamp+incrementing mode as we needed. We tried custom query, suffix and delay configuration parameters, but none satisfied our needs. We would wanted something like the reverted incrementing+timestamp mode with possibility to look behind on the timestamp column. It is very specific problem what we have, I might try to explain it in the comments if you want.

Solution

We did not want to add yet another mode or another delay / timeout configuration therefore we added the possibility to define the SELECT query parameters based on user needs. Together with already existing query configuration parameter this allows anyone to define and parametrize final SELECT fully on his own.

Does this solution apply anywhere else?
  • yes
  • no

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@ITman1 ITman1 requested a review from a team as a code owner February 2, 2023 19:11
@ITman1
Copy link
Author

ITman1 commented Feb 27, 2023

Hello @ManasjyotiSharma, @anupamaggarwal, @mukkachaitanya,

may I kindly ask you for a checking and approving this PR?

Thank you.

@cla-assistant
Copy link

cla-assistant bot commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

@baunz
Copy link

baunz commented Sep 3, 2024

This is a very useful addition to optimize source queries. Have you heard anything from Confluent and are you using this commit in production, @ITman1 ?

@ITman1
Copy link
Author

ITman1 commented Sep 3, 2024

This is a very useful addition to optimize source queries. Have you heard anything from Confluent and are you using this commit in production, @ITman1 ?

As we did not receive any feedback from Confluent we developed custom plugin which wraps the official one. So yes, we achieved to have fully custom SELECT query on production, but not in this fancy way using only one additional parameter.

@baunz
Copy link

baunz commented Sep 3, 2024

Okay, thanks for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants