Read Correct metadata for SAP Hana views #1215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lennartfries
changed the title
sagarrao12
suggested changes
Jul 12, 2022
There was a problem hiding this comment.
Thanks for the PR @lennartfries Very minor changes suggested. Also, I don't see tests for this change. Could you plz add unit tests for this? Thanks!
src/main/java/io/confluent/connect/jdbc/dialect/SapHanaDatabaseDialect.java
Outdated
Show resolved
Hide resolved
|
@sagarrao12 can we merge this now ? |
sagarrao12
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
LGTM. @mukkachaitanya / @ypmahajan could you also take a look once. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SAP Hana can not see direct views
Solution
Reopens Solutions of #1103
Does this solution apply anywhere else?
If yes, where?
Test Strategy
Testing done:
Release Plan