Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redshift dialect implementation #1214

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jirufik
Copy link

@jirufik jirufik commented Jul 7, 2022

Problem

The current implementation of kafka-connect-jdbc does not properly support Redshift. Adding multiple columns does not work. Redshift converts the TEXT type to VARCHAR(256) by default. For many data, this is a short length. Converts the date from Debezium to TEXT.

Solution

Creating a dialect for Redshift based on the modified PostgreSQL dialect.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

In the datamesh functionality of the EBAC organization https://ebaconline.com.br/

Test Strategy

Added several modules to check the Redshift language. Manual testing was carried out on the EBAC developer platform.

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

@jirufik jirufik requested a review from a team as a code owner July 7, 2022 11:30
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sagarrao12
Copy link
Contributor

Thanks for the review @jirufik .. At this point we aren't looking at new dialects. @NathanNam , can you plz confirm if this something we want to add? Thanks!

@ptqa
Copy link

ptqa commented Sep 22, 2022

I think there is no point in submitting improvements for this. As you can see confluent is not interested. There is an apache fork maintained by another team that we all need to switch to.

See https://github.com/aiven/jdbc-connector-for-apache-kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants