-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: Support Ubuntu 23.04+ #2005
base: main
Are you sure you want to change the base?
libvirt: Support Ubuntu 23.04+ #2005
Conversation
I've manually tested this on 22.04 and 24.04 and it all (non-kbs) test passed for me |
It looks like in the CI the shell reload to pick up the new path isn't working, which might be to do with GHA isolating PATH between steps, so we might need some PATH update in the workflow, so putting this in draft for now. |
I hope my workflow commit will do the trick. I'm not sure we can test it though, so maybe the best plan is to split out the workflow change and deliver it separately? |
a7ff93e
to
4de1548
Compare
In newer versions of Ubuntu running `pip3 install kcli` results in the following error: ``` error: externally-managed-environment × This environment is externally managed ╰─> To install Python packages system-wide, try apt install python3-xyz, where xyz is the package you are trying to install. ... ``` Solutions seem to be either use a virtual environment, install the package with apt (which isn't available for us as we need), or use pipx if installing an application, which we are. This attempts to use the logic to install with pipx, including a shell reload at the end of the script to force the PATH to be updated Signed-off-by: stevenhorsman <[email protected]>
With pipx to install kcli, we now need `${HOME}/.local/bin` to be added to `PATH`, so that we can pick up the install, so try exporting this to $GITHUB_PATH Signed-off-by: stevenhorsman <[email protected]>
4de1548
to
9f74299
Compare
Now we can run the libvirt x86 tests on a github hosted runner. I'm able to test this in my fork and it passes: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/12047365356/job/33590586948, so this is ready to review and merge directly. |
In newer versions of Ubuntu running
pip3 install kcli
results in the following error:Solutions seem to be either use a virtual environment, install the package with apt (which isn't available for us as we need), or use pipx if installing an application, which we are.
This attempts to use the logic to install with pipx, including a shell reload at the end of the script to force the PATH to be updated