Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create artifact #4

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Create artifact #4

merged 1 commit into from
Feb 14, 2024

Conversation

strokyl
Copy link
Collaborator

@strokyl strokyl commented Feb 14, 2024

No description provided.

@strokyl strokyl force-pushed the publish_binary_file branch 2 times, most recently from b756594 to 622d888 Compare February 14, 2024 15:45
@strokyl strokyl marked this pull request as ready for review February 14, 2024 15:57
@strokyl strokyl merged commit a23d0db into main Feb 14, 2024
3 checks passed
github_token: ${{ secrets.GITHUB_TOKEN }}
goos: ${{ matrix.goos }}
goarch: ${{ matrix.goarch }}
goversion: "https://dl.google.com/go/go1.22.0.linux-amd64.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not directly 1.22.0 ?

@@ -0,0 +1,23 @@
name: Build Docker Images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Build Docker Images
name: Build release artifacts

build-exec:
needs: [unit-test, integration-test]
name: Build exec
uses: ./.github/workflows/build-exec.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating a different workflow instead is a bit overkill for a job with only 2 steps that is used only in release workflow

@qboileau qboileau deleted the publish_binary_file branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants