Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for teleport and improve doc #19

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

strokyl
Copy link
Collaborator

@strokyl strokyl commented Mar 18, 2024

No description provided.


First login to your teleport proxy, for example:
```
tsh login --proxy=teleport-01.prd.tooling.cdkt.dev --auth=github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't give our teleport server url to in a repo that will end up public
Just say "login to your teleport server"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we will clean the doc when we make it public no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't forget ...
I've created a linear ticket for that https://linear.app/conduktor/issue/CONS-872/go-public

@@ -32,3 +32,20 @@ How to run integration test:
./test_final_exec.sh
```

## How to use behind teleport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only work if people have like us a console instance declared as teleport application, not sure that there are many

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we remove this section when we make this README.md public

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still can be useful to know that you can use cert and key to access a console behind a secured proxy

@strokyl strokyl merged commit 6819870 into main Mar 18, 2024
3 checks passed
@qboileau qboileau deleted the improve_doc_and_teleport branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants