Use {{ name }} in filename too

[jakirkham]

Description

Since {{ name }} is already templated elsewhere, template it in the filename of the archive too for consistency.

Note: This behavior was observed in comment ( conda-forge/staged-recipes#22395 (comment) )

[jakirkham]

Should add the other option would be to skip templating name everywhere and just inline it

[jakirkham]

AFAICT metadata is gotten by requesting JSON for a package on PyPI like so...

import json
import requests


name = "dask-cuda"

req = requests.get(f"https://pypi.org/pypi/{name}/json")
metadata = json.loads(req.content)

assert metadata["info"]["name"] == name

This appears valid when looking at dask-cuda on PyPI

Am I missing something?

[bollwyvl]

It looks like the fixture might be incomplete? (log)

metadata = {'info': {'version': '1.2.3'}, 'urls': [{'filename': 'foo_file-1.2.3.zip', 'packagetype': 'sdist'}]}

[bollwyvl]

I have often wished the upstream Warehouse data model was captured somewhere other than in the code for warehouse (e.g. an OpenAPI spec, some TypedDicts, really anything...)

[jakirkham]

Ah good catch! Thanks Nick 🙏

Wasn't thinking about fixtures for some reason 🤦‍♂️

Yeah was really hoping I could find some docs describing this somewhere, but was unable 😞

[bollwyvl]

all the "truth" is out there:

• https://github.com/pypi/warehouse/blob/main/warehouse/classifiers/models.py
• https://github.com/pypi/warehouse/blob/main/warehouse/packaging/models.py

There's an open issue for documenting it, but no spec as of yet.

[marcelotrevisani]

as far as I remember, pypi converts the _ to -, but it does not work for all
packages that were initially specified as having the _ will just work with it. pypi api is a bit confusing

[jakirkham]

Also looks like semver version 3.0.0 changed from isvalid to is_valid in PR ( python-semver/python-semver#368 ), which is causing some unrelated test failures

[bollwyvl]

I've found that an increasing number of packages' build chains will start spitting out *_*.tar.gz without much warning, so using the "PyPI normalized" name is less predictable than it once was. I guess i'd rather see the default be to remove {{ name }} entirely.

[jakirkham]

Am ok with that. Mainly want to be consistent with whichever approach we choose

[marcelotrevisani]

Hi folks, sorry for my delay.
I was thinking in the past to use the pypi url that gives the filename and all and just replace the version by the jinja expression {{ version}}

[marcelotrevisani]

I am a bit busy these days, I don't have much free time to take a proper look at this
I believe in a few days I can do a proper investigation into this. Thanks!

[jakirkham]

Toggling for CI

[marcelotrevisani]

is it still relevant? I remember that it is not using {{ name }} in the filename to avoid problems with - or _

[jakirkham]

Yes as we are still handling name inconsistently

That said, if we would rather inject the name and not use Jinja in the URL, that is also an option. Please see PR: #548