Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output db secret to logs #1033

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Don't output db secret to logs #1033

merged 1 commit into from
Jan 3, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Dec 31, 2024 •
edited
Loading

Description

The database_url also includes the username + password for accessing the db. Outputting this to the logs is not good.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@soapy1
Don't output conda-store db secrets to logs
11ced1c 
Te database_url also includes the username + password for accessing
the db. Outputting this to the logs is not good.
@netlify Netlify
Copy link

netlify bot commented Dec 31, 2024 •
edited
Loading

✅ Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 11ced1c
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6774448fdd9f3b0008b6aded

@soapy1 soapy1 added type: bug 🐛 Something isn't working needs: review 👀 labels Dec 31, 2024
@soapy1 soapy1 requested a review from peytondmurray January 1, 2025 19:22
peytondmurray
peytondmurray approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, thanks for catching this. I'm going to make an issue for creating a logging formatter to redact sensitive information as a follow up.

@peytondmurray peytondmurray merged commit 3af9065 into conda-incubator:main Jan 3, 2025
30 checks passed
@peytondmurray peytondmurray mentioned this pull request Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

Assignees
No one assigned
Labels
needs: review 👀 type: bug 🐛 Something isn't working
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soapy1 @peytondmurray