Rename blacklist #11
Open
Rename blacklist #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a frequent user of this package I strongly support this idea. |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 90.36% 89.27% -1.09%
==========================================
Files 3 3
Lines 415 429 +14
==========================================
+ Hits 375 383 +8
- Misses 40 46 +6
Continue to review full report at Codecov.
|
|
What about using the more common terms |
|
@xhochy i'd be fine with those too |
|
The code has changed enough that this pull request should be closed and do this over. I am definitely in favor of just using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language matters.
https://twitter.com/leahculver/status/1269109776983547904
https://twitter.com/alessandramakes/status/1269116696834437121
I'd also be in ok with any of these *-list prefixes:
This introduces a rename of blacklist -> denylist and whitelist -> allowlist. Backwards compatibility is enabled until such a time as we want to get rid of the backwards compat layer. In the warning message it says "until the next minor release", but that's sort of up to you all since you own the fork now.