Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rethinkdb-python #28348

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Add rethinkdb-python #28348

merged 6 commits into from
Nov 28, 2024

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Nov 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rethinkdb-python/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 25, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rethinkdb-python/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rethinkdb-python/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12001350131. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rethinkdb-python/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta marked this pull request as ready for review November 25, 2024 01:48
@jeongseok-meta
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

build:
number: 0
script: {{ PYTHON }} -m pip install . -vv
skip: true # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this skipped? It looks like this could be a noarch package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream package unfortunately does not support Windows (rethinkdb/rethinkdb-python#217). I initially tried making it noarch, but this failed due to binary files and other issues. This PR doesn't include a detailed history of these failures, but I can reproduce them if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it noarch and add a __unix dependency to run. This should save you a fair bit of maintenance work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. It's done in 77845af!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, now win build fails with:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "D:\a\1\s\.ci_support\build_all.py", line 356, in <module>
    build_all(os.path.join(root_dir, "recipes"), args.arch)
  File "D:\a\1\s\.ci_support\build_all.py", line 185, in build_all
    build_folders(recipes_dir, folders, arch, channel_urls)
  File "D:\a\1\s\.ci_support\build_all.py", line 248, in build_folders
    conda_build.api.build([recipe], config=get_config(arch, channel_urls))
  File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 209, in build
    return build_tree(
           ^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3655, in build_tree
    packages_from_this = build(
                         ^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 2762, in build
    newly_built_packages = bundlers[pkg_type](
                           ^^^^^^^^^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 1871, in bundle_conda
    files = post_process_files(metadata, initial_files)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 1666, in post_process_files
    noarch_python.populate_files(
  File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 95, in populate_files
    handle_file(f, d, prefix)
  File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 76, in handle_file
    fn = rewrite_script(fn, prefix)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 31, in rewrite_script
    raise CondaBuildUserError(f"Noarch package contains binary script: {fn}")
conda_build.exceptions.CondaBuildUserError: Noarch package contains binary script: rethinkdb-export.exe

Not sure if this means this package cannot be noarch or if there is a resolution that I am not aware of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy xhochy merged commit a27f4b7 into conda-forge:main Nov 28, 2024
5 of 7 checks passed
@jeongseok-meta jeongseok-meta deleted the rethinkdb branch November 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants