-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rethinkdb-python #28348
Add rethinkdb-python #28348
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
3673e86
to
9e3c92f
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/rethinkdb-python/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12001350131. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
092488a
to
4055418
Compare
@conda-forge/help-python, ready for review! |
recipes/rethinkdb-python/meta.yaml
Outdated
build: | ||
number: 0 | ||
script: {{ PYTHON }} -m pip install . -vv | ||
skip: true # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this skipped? It looks like this could be a noarch package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream package unfortunately does not support Windows (rethinkdb/rethinkdb-python#217). I initially tried making it noarch, but this failed due to binary files and other issues. This PR doesn't include a detailed history of these failures, but I can reproduce them if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it noarch
and add a __unix
dependency to run
. This should save you a fair bit of maintenance work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. It's done in 77845af!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, now win build fails with:
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a\1\s\.ci_support\build_all.py", line 356, in <module>
build_all(os.path.join(root_dir, "recipes"), args.arch)
File "D:\a\1\s\.ci_support\build_all.py", line 185, in build_all
build_folders(recipes_dir, folders, arch, channel_urls)
File "D:\a\1\s\.ci_support\build_all.py", line 248, in build_folders
conda_build.api.build([recipe], config=get_config(arch, channel_urls))
File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 209, in build
return build_tree(
^^^^^^^^^^^
File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3655, in build_tree
packages_from_this = build(
^^^^^^
File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 2762, in build
newly_built_packages = bundlers[pkg_type](
^^^^^^^^^^^^^^^^^^^
File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 1871, in bundle_conda
files = post_process_files(metadata, initial_files)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 1666, in post_process_files
noarch_python.populate_files(
File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 95, in populate_files
handle_file(f, d, prefix)
File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 76, in handle_file
fn = rewrite_script(fn, prefix)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Miniforge\Lib\site-packages\conda_build\noarch_python.py", line 31, in rewrite_script
raise CondaBuildUserError(f"Noarch package contains binary script: {fn}")
conda_build.exceptions.CondaBuildUserError: Noarch package contains binary script: rethinkdb-export.exe
Not sure if this means this package cannot be noarch
or if there is a resolution that I am not aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to specify the Python entry_points as seen in https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#python-entry-points
77845af
to
12e100e
Compare
Co-authored-by: Filipe <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).