Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Windows reset Spyder settings shortcut to a separate json file #204

Merged
merged 5 commits into from
Nov 24, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Nov 21, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Address conda/menuinst#274
Fixes spyder-ide/spyder#23062

Multiple shortcuts in one json cannot be reserved for specific platforms.
Do not use separate reset shortcut json with menuinst v1
@mrclary
Copy link
Contributor Author

mrclary commented Nov 21, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

conda-forge-webservices[bot] and others added 2 commits November 21, 2024 01:49
@mrclary mrclary marked this pull request as ready for review November 22, 2024 01:32
@mrclary
Copy link
Contributor Author

mrclary commented Nov 22, 2024

@ccordoba12 this is ready for review. I tested the Azure artifact on macOS and Windows VM.

@ccordoba12 ccordoba12 added the bug label Nov 24, 2024
@ccordoba12 ccordoba12 changed the title Multi shortcut Move Windows reset Spyder settings shortcut to a separate json Nov 24, 2024
@mrclary
Copy link
Contributor Author

mrclary commented Nov 24, 2024

...and the REQUIRED.app is no longer created.

Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mrclary!

@ccordoba12 ccordoba12 changed the title Move Windows reset Spyder settings shortcut to a separate json Move Windows reset Spyder settings shortcut to a separate json file Nov 24, 2024
@ccordoba12 ccordoba12 merged commit 8758d1d into conda-forge:main Nov 24, 2024
9 checks passed
@mrclary mrclary deleted the multi-shortcut branch November 24, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUIRED.app is installed by Spyder macOS installer
3 participants