Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest included with rtree #53

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Jul 10, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR runs the upstream rtree tests with pytest. It is called within the existing run_test.py script.

@mwtoews mwtoews requested review from hobu and ocefpaf as code owners July 10, 2024 09:55
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mwtoews mwtoews changed the title Rtree pytest Run pytest included with rtree Jul 10, 2024
@hobu
Copy link
Contributor

hobu commented Jul 10, 2024

We seem to be not very happy on pypy

@mwtoews
Copy link
Member Author

mwtoews commented Jul 10, 2024

There are actually two issues. One issue is tracked upstream, and skipped here for PyPy.

However, the second issue is a segmentation fault while running pytest on some PyPy platforms e.g.

===== testing package: rtree-1.3.0-py39h2fb8f80_1 =====
running run_test.py
============================= test session starts ==============================
platform linux -- Python 3.9.18[pypy-7.3.15-final], pytest-8.2.2, pluggy-1.5.0 -- $PREFIX/bin/python
cachedir: .pytest_cache
rootdir: $SRC_DIR
/home/conda/feedstock_root/build_artifacts/rtree_1720650761615/test_tmp/conda_test_runner.sh: line 3:  1280 Segmentation fault      (core dumped) "/home/conda/feedstock_root/build_artifacts/rtree_1720650761615/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/bin/python" -s "/home/conda/feedstock_root/build_artifacts/rtree_1720650761615/test_tmp/run_test.py"
WARNING: Tests failed for rtree-1.3.0-py39h2fb8f80_1.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: rtree-1.3.0-py39h2fb8f80_1.conda

For instance, this issue:

  • seg fault with linux_aarch64_numpy1.22python3.9.____73_pypy
  • clean run with linux_64_numpy1.22python3.9.____73_pypy

It could be due to the awkwardness of numpy with pypy. I'll try once more to see if pytest can run only with PyPy on linux_64...

@hobu
Copy link
Contributor

hobu commented Jul 11, 2024

please merge this when you're happy with it. I don't know that we officially supported pypy with Rtree anyway.

@mwtoews
Copy link
Member Author

mwtoews commented Jul 11, 2024

Lets keep the test for now, but if PyPy acts up in the future, then we can remove the test and decide to disable PyPy support.

@mwtoews mwtoews merged commit b786b66 into conda-forge:main Jul 11, 2024
37 checks passed
@mwtoews mwtoews deleted the rtree-pytest branch July 11, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants