-
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3 from regro-cf-autotick-bot/rebuild-numpy2-0-1_h…
…ed4782 Rebuild for numpy 2.0
- Loading branch information
Showing
15 changed files
with
133 additions
and
51 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
__migrator: | ||
build_number: 1 | ||
kind: version | ||
commit_message: | | ||
Rebuild for numpy 2.0 | ||
TL;DR: The way we build against numpy has changed as of numpy 2.0. This bot | ||
PR has updated the recipe to account for the changes (see below for details). | ||
The numpy 2.0 package itself is currently only available from a special release | ||
channel (`conda-forge/label/numpy_rc`) and will not be available on the main | ||
`conda-forge` channel until the release of numpy 2.0 GA. | ||
The biggest change is that we no longer need to use the oldest available numpy | ||
version at build time in order to support old numpy version at runtime - numpy | ||
will by default use a compatible ABI for the oldest still-supported numpy versions. | ||
Additionally, we no longer need to use `{{ pin_compatible("numpy") }}` as a | ||
run requirement - this has been handled for more than two years now by a | ||
run-export on the numpy package itself. The migrator will therefore remove | ||
any occurrences of this. | ||
However, by default, building against numpy 2.0 will assume that the package | ||
is compatible with numpy 2.0, which is not necessarily the case. You should | ||
check that the upstream package explicitly supports numpy 2.0, otherwise you | ||
need to add a `- numpy <2` run requirement until that happens (check numpy | ||
issue 26191 for an overview of the most important packages). | ||
Note that the numpy release candidate promises to be ABI-compatible with the | ||
final 2.0 release. This means that building against 2.0.0rc1 produces packages | ||
that can be published to our main channels. | ||
If you already want to use the numpy 2.0 release candidate yourself, you can do | ||
``` | ||
conda config --add channels conda-forge/label/numpy_rc | ||
``` | ||
or add this channel to your `.condarc` file directly. | ||
### To-Dos: | ||
* [ ] Match run-requirements for numpy (i.e. check upstream `pyproject.toml` or however the project specifies numpy compatibility) | ||
* If upstream is not yet compatible with numpy 2.0, add `numpy <2` upper bound under `run:`. | ||
* If upstream is already compatible with numpy 2.0, nothing else should be necessary in most cases. | ||
* If upstream requires a minimum numpy version newer than 1.19, you can add `numpy >=x.y` under `run:`. | ||
* [ ] Remove any remaining occurrences of `{{ pin_compatible("numpy") }}` that the bot may have missed. | ||
PS. If the build does not compile anymore, this is almost certainly a sign that | ||
the upstream project is not yet ready for numpy 2.0; do not close this PR until | ||
a version compatible with numpy 2.0 has been released upstream and on this | ||
feedstock (in the meantime, you can keep the bot from reopening this PR in | ||
case of git conflicts by marking it as a draft). | ||
migration_number: 1 | ||
exclude: | ||
# needs local overrides that get stomped on by the migrator, which then fails | ||
- scipy | ||
# already done, but thinks its unsolvable | ||
- pandas | ||
ordering: | ||
# prefer channels including numpy_rc (otherwise smithy doesn't | ||
# know which of the two values should be taken on merge) | ||
channel_sources: | ||
- conda-forge | ||
- conda-forge/label/numpy_rc,conda-forge | ||
|
||
# needs to match length of zip {python, python_impl, numpy} | ||
# as it is in global CBC in order to override it | ||
numpy: | ||
- 1.22 # no py38 support for numpy 2.0 | ||
- 2.0 | ||
- 2.0 | ||
- 2.0 | ||
- 2.0 | ||
channel_sources: | ||
- conda-forge/label/numpy_rc,conda-forge | ||
migrator_ts: 1713572489.295986 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
47ed50b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! This is the friendly automated conda-forge-webservice.
I updated the Github team because of this commit.
Go to https://github.com/orgs/conda-forge/invitation see your invitation.
You should get push access to this feedstock and CI services.
Your package won't be available for installation locally until it is built
and synced to the anaconda.org CDN (takes 1-2 hours after the build finishes).
Feel free to join the community Element channel.
NOTE: Please make sure to not push to the repository directly.
Use branches in your fork for any changes and send a PR.
More details on this are here.