-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-smithy 3.23.0 #246
conda-smithy 3.23.0 #246
Changes from 4 commits
50dc30e
654f9ab
02fca5a
db01232
7bf3a78
940c0ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{% set version = "3.22.1" %} | ||
{% set version = "3.23.0" %} | ||
|
||
package: | ||
name: conda-smithy | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/conda-forge/conda-smithy/releases/download/v{{ version }}/conda-smithy-{{ version }}.tar.gz | ||
sha256: 7d8c766ced494aada59f56b2693411c212826c685b762b467d2070120d66c275 | ||
sha256: 6808967b9dc81bb42200441a7dc60e13492095db64ca53d4e21ce72119bb58a8 | ||
|
||
build: | ||
number: 0 | ||
|
@@ -23,6 +23,9 @@ requirements: | |
host: | ||
- python >=3.6 | ||
- pip | ||
- setuptools >=45 | ||
- setuptools-scm >=7 | ||
- tomli >=1.0.0 | ||
run: | ||
- python >=3.6 | ||
- setuptools | ||
|
@@ -40,6 +43,7 @@ requirements: | |
- vsts-python-api | ||
- toolz | ||
- scrypt | ||
- shellcheck | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Support for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was removed in https://github.com/conda-forge/conda-smithy-feedstock/pull/188/files because of some issue I don't remember. Maybe shellcheck crashed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm...ok. Thanks for that detail. Unfortunate we don't have more history in that PR. Maybe @beckermr remembers more details? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t recall either way but we don’t currently use it in conda forge for sure. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was it related to issue ( conda-forge/conda-smithy#1316 )? AFAICT everything there has been fixed ( conda-forge/conda-smithy#1316 (comment) ) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thought There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We wouldn’t be able to even use smithy on ppc64le regardless of the linter. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could add Edit: Would that be a fair compromise in general here? Considering we are concerned about fallout from making it a hard requirement? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note: Created PR ( conda-forge/shellcheck-feedstock#13 ) to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Getting |
||
- license-expression | ||
- libarchive | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these to line up with upstream build requirements included in this release