Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the migration table into 3 different tables #2250

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Jul 31, 2024

Split the migration table into 3 different tables with individual sorting

PR Checklist:

  • note any issues closed by this PR with closing keywords
  • if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • put any other relevant information below

This PR aims at fixing task 11 of issue #2137
This fixed is proposed by @afshin and is built on main version with commit header on 27f447d.
It is an alternative of merged PR #2248 that has the drawback of introducing some differences in the width of the columns table and is not enabling to sort each subtable separately.

Uploading Screencast from 31-07-2024 17:16:51.webm…

@HaudinFlorence HaudinFlorence requested a review from a team as a code owner July 31, 2024 15:06
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 2f0d060
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/66aa88cd431f5c000847ca68
😎 Deploy Preview https://deploy-preview-2250--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HaudinFlorence HaudinFlorence force-pushed the split_migration_table_into_three_separate_subtables_with_individual_sorting branch from fb0ac30 to 5f79f90 Compare July 31, 2024 15:10
@jaimergp
Copy link
Member

Love it! Thanks!

@jakirkham - wdyt about the table headers now?

@beckermr
Copy link
Member

I think the title for the closed one should be "Recently Closed Migrators".

@HaudinFlorence
Copy link
Contributor Author

I think the title for the closed one should be "Recently Closed Migrators".

This has been changed.

@jakirkham
Copy link
Member

LGTM. Thank you! 🙏

@beckermr beckermr merged commit 0f0d041 into conda-forge:main Jul 31, 2024
6 checks passed
@afshin afshin mentioned this pull request Aug 1, 2024
16 tasks
jaimergp added a commit to jaimergp/conda-forge.github.io that referenced this pull request Aug 1, 2024
jaimergp added a commit that referenced this pull request Aug 1, 2024
* Revert changes undone by merge in #2250

* pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants