Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: provide a way to suppress the doc build when doing a make / make all #222

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

pkelsey
Copy link
Contributor

@pkelsey pkelsey commented Mar 19, 2024

A variable EXTRA_BUILD is defined, with a default value of 'doc', that establishes additional dependencies of the 'all' make target. This allows disabling the doc build during make / make all by passing 'EXTRA_BUILD=' on the configure command line.

This relies on the fix for name=value command line arg processing in PR #219.

A variable EXTRA_BUILD is defined, with a default value of 'doc', that
establishes additional dependencies of the 'all' make target.  This
allows disabling the doc build during make / make all by passing
'EXTRA_BUILD=' on the configure command line.

This relies on the fix for name=value command line arg processing.
@cognet
Copy link
Contributor

cognet commented Mar 20, 2024

Hi @pkelsey !

I assume removing PPC32_LWSYNC was not intentional ?

@pkelsey
Copy link
Contributor Author

pkelsey commented Mar 20, 2024

Hi @pkelsey !

I assume removing PPC32_LWSYNC was not intentional ?

Definitely not intentional - apparently a strange side effect of splitting

Hi @pkelsey !

I assume removing PPC32_LWSYNC was not intentional ?

Definitely not intentional, and seems to be a side effect of having split this patch sequence up into independent patches against master, which did involve some manual deconfliction - I'm guessing that line somehow got killed in the editor along the way? Anyhow, please ignore.

@cognet cognet merged commit 8a8704d into concurrencykit:master Mar 20, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants