Adding IAM roles to the cred chain #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
Signed-off-by: jduv <[email protected]>
1 task
|
Thanks for submitting this! As mentioned in concourse/concourse#3023 though I'm going to put this on hold until we figure out how we want to support IAM roles in the context of concourse/concourse#2386. |
|
Closing this one too - see concourse/s3-resource#115 (comment). Thanks again! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to our other PRs in other resources, we'd like to add the default IAM cred chain to resources with no static keys defined. This implementation is very close to what I did in the s3-resource, so the code should look familiar.
concourse/s3-resource#115
All tests pass, and we've been running this in production for a week now.
https://cloud.docker.com/u/7factor/repository/docker/7factor/semver-resource