-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds optional depth parameter for specifying the number of git commits #50
Conversation
to be cloned. Authored-by: Maryam Labib <[email protected]> Co-authored-by: Soumya GB <[email protected]> Signed-off-by: Maryam Labib <[email protected]> Signed-off-by: Soumya GB <[email protected]>
Authored-by: Maryam Labib <[email protected]> Co-authored-by: Soumya Gb <[email protected]> Signed-off-by: Maryam Labib <[email protected]> Signed-off-by: Soumya Gb <[email protected]>
ce6f3c9
to
b47410b
Compare
Any updates on merging this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! sorry for the delay, it's pretty hard keeping up with all these resources.
concourse/pool-resource#50 Signed-off-by: Jamie Klassen <[email protected]> Co-authored-by: James Thomson <[email protected]>
concourse/pool-resource#50 Signed-off-by: Jamie Klassen <[email protected]> Co-authored-by: James Thomson <[email protected]>
Is there ever a time where we wouldn't want the I'd suggest setting the default value to be |
Based on concourse#50 (comment) Signed-off-by: Sean M. Collins <[email protected]>
Based on concourse#50 (comment) Signed-off-by: Sean M. Collins <[email protected]>
"Some of the lock repos can get super big really fast, especially if multiple teams/pipelines are using the same repo. An idea is to use shallow clones, since we don't necessarily need the full history of the repo, we just need the latest state."
We wanted to implement the behavior that was requested in issue: #40
This behaves the same exact way as the git-resource, as we wanted to maintain consistency. This is a parameter on the
get
step, the same way as described here: https://github.com/concourse/git-resource#in-clone-the-repository-at-the-given-refAuthored-by: Maryam Labib [email protected]
co-authored by: Soumya GB [email protected]
Signed off by: Maryam Labib [email protected]
Signed off by: Soumya GB [email protected]