Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional depth parameter for specifying the number of git commits #50

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

maryamklabib
Copy link
Contributor

"Some of the lock repos can get super big really fast, especially if multiple teams/pipelines are using the same repo. An idea is to use shallow clones, since we don't necessarily need the full history of the repo, we just need the latest state."

We wanted to implement the behavior that was requested in issue: #40

This behaves the same exact way as the git-resource, as we wanted to maintain consistency. This is a parameter on the get step, the same way as described here: https://github.com/concourse/git-resource#in-clone-the-repository-at-the-given-ref

Authored-by: Maryam Labib [email protected]
co-authored by: Soumya GB [email protected]

Signed off by: Maryam Labib [email protected]
Signed off by: Soumya GB [email protected]

to be cloned.

Authored-by: Maryam Labib <[email protected]>
Co-authored-by: Soumya GB <[email protected]>

Signed-off-by: Maryam Labib <[email protected]>
Signed-off-by: Soumya GB <[email protected]>
Authored-by: Maryam Labib <[email protected]>
Co-authored-by: Soumya Gb <[email protected]>

Signed-off-by: Maryam Labib <[email protected]>
Signed-off-by: Soumya Gb <[email protected]>
@maryamklabib
Copy link
Contributor Author

Any updates on merging this PR?

Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! sorry for the delay, it's pretty hard keeping up with all these resources.

@vito vito merged commit df77259 into concourse:master Aug 1, 2019
jamieklassen pushed a commit to concourse/concourse that referenced this pull request Sep 4, 2019
concourse/pool-resource#50

Signed-off-by: Jamie Klassen <[email protected]>
Co-authored-by: James Thomson <[email protected]>
matthewpereira pushed a commit to concourse/concourse that referenced this pull request Sep 5, 2019
concourse/pool-resource#50

Signed-off-by: Jamie Klassen <[email protected]>
Co-authored-by: James Thomson <[email protected]>
@sc68cal
Copy link
Contributor

sc68cal commented Nov 8, 2019

Is there ever a time where we wouldn't want the depth to be 1?

I'd suggest setting the default value to be 1 so that users that end up with big lock pool histories don't have to go and hunt for this parameter once their lock pool gets big enough for this to be a problem. I haven't looked through the code for this resource, but if there isn't any conflict resolution in this repo for handling history merges, what is the point of downloading all the history?

sc68cal added a commit to sc68cal/pool-resource that referenced this pull request Nov 8, 2019
sc68cal added a commit to sc68cal/pool-resource that referenced this pull request Nov 8, 2019
sc68cal added a commit to sc68cal/pool-resource that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants