-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing secrets as text (#78) #88
Conversation
Signed-off-by: Charles Duffy <[email protected]>
8847b03
to
8ae2cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test for this new env var. Let me see where that would go. I'll drop you some pointers / a test you can copy-paste from.
You can use this test as as starting point: Lines 253 to 259 in a46d096
That test makes use of the test data here: https://github.com/concourse/oci-build-task/tree/master/testdata/buildkit-secret |
adf2c43
to
d6b96de
Compare
d6b96de
to
c854289
Compare
Signed-off-by: Charles Duffy <[email protected]>
c854289
to
eee09ac
Compare
@taylorsilva -- do the changes meet your expectations wrt test suite coverage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - test coverage is fine. Thanks for the PR!
To preserve the existing meaning of
BUILDKIT_SECRET_
, a newBUILDKIT_SECRETTEXT_
prefix is added, which writes content to a file before adding corresponding entry to theBuildkitSecrets
map.These contents are created in
buildkit-secrets/
inside the default temporary directory; since the Docker container this all happens in is transient, no need to clean them up.See #78 for motivation.