Allow Build to continue if cache pull fails #250
Conversation
|
@john681611 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@john681611 Thank you for signing the Contributor License Agreement! |
|
Any update on when this will be merged? |
There was a problem hiding this comment.
@stijndehaes Sorry for the delay, holiday season really slowed things down!
assets/out
Outdated
| @@ -147,7 +147,7 @@ elif [ -n "$build" ]; then | |||
| cache_from_args=() | |||
|
|
|||
| if [ "$cache" = "true" ]; then | |||
| docker_pull "${repository}:${cache_tag}" | |||
| docker_pull "${repository}:${cache_tag}" && | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Signed-off-by: john681611 <[email protected]>
Signed-off-by: john681611 <[email protected]>
Signed-off-by: john681611 <[email protected]>
|
Cool thanks guys, Q: does this get auto released? |
|
@john681611 Doesn't get auto-released, I just kicked off a build for v1.1 though! |
##Problem
Builds would fail if the cached pull failed, this caused problems when first running an automated build and no image exists in the repository.
Solution
Stop
--cache-frombeing added if the docker pull failsTesting
Added tests for basic caching parameter and what happens if it fails to pull
Fixes #222