Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog with v17 info #307

Merged
merged 2 commits into from
Jun 6, 2022
Merged

update changelog with v17 info #307

merged 2 commits into from
Jun 6, 2022

Conversation

xtremerui
Copy link
Contributor

refer to #290

@xtremerui xtremerui requested a review from chenbh June 6, 2022 20:52
@chenbh
Copy link
Contributor

chenbh commented Jun 6, 2022

Is there no updates needed for the actual values.yaml?

concourse-chart/values.yaml

Lines 2613 to 2679 in 38a7afb

## Configuration values for the postgresql dependency.
## Ref: https://github.com/bitnami/charts/blob/master/bitnami/postgresql/README.md
##
postgresql:
## Use the PostgreSQL chart dependency.
##
## Set to false if bringing your own PostgreSQL, and set the corresponding `secrets`
## fields that correspond to the PostgreSQL variables that `concourse web` should use
## to connect to.
##
## Should be set to false if using the chart as a worker only deployment.
##
enabled: true
## Provide a name to substitute for the full name of postgresql resources
## ps.: Resources will not be appended with "-postgresql"
##
fullnameOverride:
auth:
### PostgreSQL User to create.
##
username: concourse
## PostgreSQL Password for the new user.
## If not set, a random 10 characters password will be used.
##
password: concourse
## PostgreSQL Database to create.
##
database: concourse
## Allows for setting a specific cluster ip for the PostgreSQL
## service.
service:
clusterIP:
## Persistent Volume Storage configuration for PostgreSQL.
##
## Ref: https://kubernetes.io/docs/user-guide/persistent-volumes
##
persistence:
## Enable PostgreSQL persistence using Persistent Volume Claims.
##
enabled: true
## Persistent Volume Storage Class to be used by PersistentVolumes created
## for PostgreSQL.
##
## If defined, storageClassName: <storageClass>
## If set to "-", storageClassName: "", which disables dynamic provisioning
## If undefined (the default) or set to null, no storageClassName spec is
## set, choosing the default provisioner. (gp2 on AWS, standard on
## GKE, AWS & OpenStack)
##
storageClass:
## Persistent Volume Access Mode.
##
accessModes:
- ReadWriteOnce
## Persistent Volume Storage Size.
##
size: 8Gi

EDIT: Ahh I see that was done in #306

@chenbh
Copy link
Contributor

chenbh commented Jun 6, 2022

Actually that bitnami/postgresql URL should probably be pinned to a specific version instead of master as well

Copy link
Contributor

@chenbh chenbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xtremerui xtremerui merged commit 0938739 into master Jun 6, 2022
@xtremerui xtremerui deleted the v17-change-log branch June 6, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants