Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed instance groups update mechanism to serial #187

Closed

Conversation

alexbakar
Copy link

Signed-off-by: Alexander Bakardzhiev [email protected]

Related to concourse/concourse-bosh-release#44
If the instance groups are updated in parallel, race conditions between the (instance group of) web nodes and (instance group of) worker nodes may happen, for example as with the case of long-running draining mentioned in the above issue. Making the instance groups update serial would avoid such race conditions.
*Note that this change won't affect how the instances in the instance groups are updated (they can still be updated in parallel as "max_in_flight" is set to 3.

@taylorsilva taylorsilva requested a review from vito January 13, 2020 22:59
@vito vito self-assigned this Apr 17, 2020
Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long turnaround!

We should probably make this configurable, i.e. with a separate ops-file. It makes sense that this would be problem for a deployment with only one web node, but in principle for larger clusters it's desireable to keep parallel updates.

@vito
Copy link
Member

vito commented May 28, 2020

Going to close this out since it seems inactive, but happy to re-review later. Sorry again for the slow response.Going to close this out since it seems inactive, but happy to re-review later. Sorry again for the slow response.

@vito vito closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants