feat: Chat with LLM (PT-188527956) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoldowsky
approved these changes
Dec 10, 2024
src/models/assistant-model.ts
Outdated
Comment on lines
72
to
74
| while (runState.status !== "completed" && runState.status !== "requires_action") { | ||
| runState = yield davai.beta.threads.runs.retrieve(self.thread.id, run.id); | ||
| } |
There was a problem hiding this comment.
This loop worries me. If the state is something like "canceled" or "failed", wouldn't it loop forever? And if it just takes a while to complete, is it going to be calling the API every millisecond to check on it?
There was a problem hiding this comment.
Good point. This will be addressed in separate branch.
src/models/assistant-model.ts
Outdated
Comment on lines
156
to
163
| const response = yield fetch(`${process.env.REACT_APP_OPENAI_BASE_URL}threads/${threadId}`, { | ||
| method: "DELETE", | ||
| headers: { | ||
| Authorization: `Bearer ${process.env.REACT_APP_OPENAI_API_KEY}`, | ||
| "OpenAI-Beta": "assistants=v2", | ||
| "Content-Type": "application/json", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This feels like it should be in a utility class. Surprising that the library doesn't give you a method for it and you have to construct the http headers yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188527956
These changes allow the plugin to connect with an LLM for basic chat functionality via the OpenAI API. In addition, they:
get_attributesandcreate_graph. These are basic proof-of-concept functions for interaction with CODAP. More will be added by work on a separate story.