Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add "engines" to package.json (PT-185071892) #786

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

433eros
Copy link

@433eros 433eros commented May 4, 2023

No description provided.

@433eros 433eros requested a review from kswenson May 4, 2023 18:14
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (cfacd28) 81.56% compared to head (19ddcd6) 81.54%.
Report is 1064 commits behind head on main.

❗ Current head 19ddcd6 differs from pull request most recent head 6bef9ab. Consider uploading reports for the commit 6bef9ab to get more accurate results

Files Patch % Lines
v3/src/components/graph/components/background.tsx 50.87% 26 Missing and 2 partials ⚠️
v3/src/utilities/mst-utils.ts 42.10% 9 Missing and 2 partials ⚠️
...omponents/graph/models/data-configuration-model.ts 54.54% 5 Missing ⚠️
v3/src/components/graph/components/chartdots.tsx 80.95% 4 Missing ⚠️
v3/src/components/graph/hooks/use-plot.ts 81.81% 3 Missing and 1 partial ⚠️
v3/src/components/slider/editable-slider-value.tsx 72.72% 3 Missing ⚠️
v3/src/components/graph/components/graph-axis.tsx 33.33% 1 Missing and 1 partial ⚠️
v3/src/components/graph/models/graph-controller.ts 83.33% 2 Missing ⚠️
v3/src/components/slider/use-slider-animation.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   81.56%   81.54%   -0.02%     
==========================================
  Files         218      220       +2     
  Lines        8750     8758       +8     
  Branches     2389     2369      -20     
==========================================
+ Hits         7137     7142       +5     
+ Misses       1537     1535       -2     
- Partials       76       81       +5     
Flag Coverage Δ
cypress 60.82% <71.54%> (-0.25%) ⬇️
jest 55.65% <41.69%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kswenson kswenson changed the title chore: add "engines" to packages.json (PT-185071892) chore: add "engines" to package.json (PT-185071892) May 5, 2023
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The engineStrict field is no longer used, so its presence here would only be confusing: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#enginestrict.

@433eros 433eros requested a review from kswenson May 5, 2023 13:32
433eros added a commit to concord-consortium/cloud-file-manager that referenced this pull request May 5, 2023
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kswenson kswenson added the v3 CODAP v3 label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants