-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add "engines" to package.json (PT-185071892) #786
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 81.56% 81.54% -0.02%
==========================================
Files 218 220 +2
Lines 8750 8758 +8
Branches 2389 2369 -20
==========================================
+ Hits 7137 7142 +5
+ Misses 1537 1535 -2
- Partials 76 81 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The engineStrict
field is no longer used, so its presence here would only be confusing: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#enginestrict.
"engineStrict" in 'package.json' is deprecated, see concord-consortium/codap#786 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
No description provided.