Item-level formula evaluation basic implementation #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 17, 2018 10:51
- Case value retrieval: Removed the restriction for formula evaluation that had limited reference to the collection level. - Pre-fill the collection model with evaluated formula values to ensure proper table regeneration.
- Regenerate collection cases when 1) case values changes 2) formula changes to ensure proper table structure.
- The previous commit's 1) regen when case-value updates was not working (it was working only when adding a new case).
…into wip-item-formula
|
@jsandoe Please review. Thanks! |
jsandoe
reviewed
Dec 19, 2018
There was a problem hiding this comment.
Taka, I am concerned about the increase in the number of calls to regenerateCollectionCases. This is a very expensive operation as currently implemented, especially with larger data sets. I am going to download this PR branch and try to see if I can quantify any performance degradation we might incur.
Jonathan
|
That is fair. I guess these regenerateCollectionCases could use conditionals with dependent (formula) and dependency (attributes used by formula) checks rather than blind calls, but I couldn't get to the bottom of those yet. With globals concerned, the current code needs some changes in how to determine the type of dependency (simple vs aggregate dependency). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.