master states:442 distribute update token, and enable doil to trigger instance updates via url #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klees
requested changes
Sep 6, 2024
setup/conf/doil.conf
Outdated
| global_instances_path=/srv/instances | ||
| update_token=foobar |
There was a problem hiding this comment.
Bitte entferne das, so dass das Feature per default nicht aktiviert ist. Wenn das Feld nicht gesetzt ist, ist das Feature nicht aktiv, korrekt? Bitte dann auch die entsprechenden Dateien etc. auch nicht an die Clients ausliefern.
| @@ -121,6 +121,7 @@ The following commands are available: | |||
| * `doil delete <instance_name>` deletes an instance you do not need anymore | |||
| * `doil status` lists the current running doil instances | |||
| * `doil exec <instance_name> <cmd>` executes a bash command inside the instance | |||
| * `doil sut` (alias for `doil instances:set-update-token`) Sets an update token as an environment variable. This is cross-checked during instance updates via the browser | |||
There was a problem hiding this comment.
Bitte in der README die Funktionalität ein bisschen beschreiben, so dass sie auch ohne Geheimwissen eingesetzt werden kann.
|
|
||
| if ($environment_token !== $request_token) { | ||
| http_response_code(401); | ||
| throw new Exception("Invalid Token"); |
There was a problem hiding this comment.
Bitte hier jeweils nur "Authorization required" zurückmelden in allen Fällen.
|
Hey @daniwe4, wann geht es mit diesem hier weiter? Viele Grüße! |
daniwe4
force-pushed
the
master_442
branch
2 times, most recently
from
b203901 to
214cc35
Compare
instance updates via url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.