Merge pull request #179 from tnramalho/feature/cache-swagger-updates

chore: add validations
conceptadev · Jun 28, 2024 · a9a647f · a9a647f
2 parents 67bed32 + c3dc207
commit a9a647f
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 0 deletions.
diff --git a/packages/nestjs-cache/src/controllers/cache-crud.controller.e2e-spec.ts b/packages/nestjs-cache/src/controllers/cache-crud.controller.e2e-spec.ts
@@ -191,6 +191,53 @@ describe('CacheAssignmentController (e2e)', () => {
       });
   });
 
+  it('POST /cache/user null after create', async () => {
+    interface ExtendedCacheCreatableInterface
+      extends Pick<
+        CacheCreatableInterface,
+        'key' | 'expiresIn' | 'type' | 'data'
+      > {
+      assignee: { id: string | null } | null;
+    }
+    const payload: ExtendedCacheCreatableInterface = {
+      key: 'dashboard-1',
+      type: 'filter',
+      data: '{}',
+      expiresIn: '1d',
+      assignee: { id: user.id },
+    };
+
+    await supertest(app.getHttpServer())
+      .post('/cache/user')
+      .send(payload)
+      .expect(201)
+      .then((res) => {
+        expect(res.body.key).toBe(payload.key);
+        expect(res.body.assignee.id).toBe(user.id);
+      });
+
+    payload.data = '{ "name": "John Doe" }';
+    payload.expiresIn = null;
+    payload.assignee = { id: null };
+
+    await supertest(app.getHttpServer())
+      .post('/cache/user')
+      .send(payload)
+      .expect(400);
+
+    payload.assignee = { id: '' };
+    await supertest(app.getHttpServer())
+      .post('/cache/user')
+      .send(payload)
+      .expect(500);
+
+    payload.assignee = null;
+    await supertest(app.getHttpServer())
+      .post('/cache/user')
+      .send(payload)
+      .expect(400);
+  });
+
   it('POST /cache/user Update', async () => {
     const payload: CacheCreatableInterface = {
       key: 'dashboard-1',

diff --git a/packages/nestjs-cache/src/services/cache.service.ts b/packages/nestjs-cache/src/services/cache.service.ts
@@ -270,6 +270,9 @@ export class CacheService implements CacheServiceInterface {
     const { key, type, assignee } = cache;
     try {
       const repo = repoProxy.repository(queryOptions);
+      if (!key || !type || !assignee || !assignee.id) {
+        return null;
+      }
       const cache = await repo.findOne({
         where: {
           key,

diff --git a/packages/nestjs-common/src/reference/reference-id.dto.ts b/packages/nestjs-common/src/reference/reference-id.dto.ts
@@ -1,6 +1,7 @@
 import { Exclude, Expose } from 'class-transformer';
 import { ApiProperty } from '@nestjs/swagger';
 import { ReferenceIdInterface } from '@concepta/ts-core';
+import { IsString } from 'class-validator';
 
 @Exclude()
 export class ReferenceIdDto implements ReferenceIdInterface {
@@ -9,5 +10,6 @@ export class ReferenceIdDto implements ReferenceIdInterface {
     type: 'string',
     description: 'Unique identifier',
   })
+  @IsString()
   id = '';
 }