Fixed compatibility with Django 1.10 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any change of getting this merged? |
FFX01
reviewed
Sep 26, 2016
tastypie_swagger/urls.py
Outdated
| from django import get_version | ||
| from distutils.version import StrictVersion | ||
|
|
||
| if StrictVersion(get_version()) < StrictVersion("1.10"): |
There was a problem hiding this comment.
May want to change this to check for a version before 1.8 or 1.9 as the new list-style url patterns are supported in both of those versions and 1.9 throws a warning with the wrapped patterns.
There was a problem hiding this comment.
Edited and checked on 1.8, 1.9 and 1.10.
|
Will this be merged? Support of 1.10 would be really helpful ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #116. Fixed
RemovedInDjango110Warning : django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.. Checked work on Django 1.9 and 1.10.