Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a recipe template #9841

Merged
merged 5 commits into from
May 16, 2022

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Mar 18, 2022

this can help new contributors, and reviewers too.

This is a very quick draft.
We should probably also add more comments to this template, in order to explain all these conventions.
Also, if you find this template could be useful, then we should link to it from the documentation .md files

I added all CCI's approved reviewers as contributor to my fork, so please edit the files directly, instead of doing code suggestion.

this partially answers item 3. in #2857 (comment)

this can help new contributors, and reviewers too
@conan-center-bot

This comment has been minimized.

@danimtb
Copy link
Member

danimtb commented Mar 18, 2022

It would be very nice if combined with the conan new --template command https://docs.conan.io/en/latest/extending/template_system/command_new.html#template-command-new

@ericLemanissier
Copy link
Contributor Author

@SpaceIm maybe you have some sort of checklist you use for modernization of recipes ? Can it somehow be translated into this template ?

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 18, 2022

maybe you have some sort of checklist you use for modernization of recipes ?

Somewhere in my head yes. I'll take a look.

intelligide
intelligide previously approved these changes Mar 21, 2022
@SSE4
Copy link
Contributor

SSE4 commented Mar 22, 2022

I also had some templates, but didn't update them for a while: https://github.com/SSE4/cci.templates

SSE4
SSE4 previously approved these changes Mar 22, 2022
@ericLemanissier
Copy link
Contributor Author

I'll do a pr on your repo then. It's more usable as a proper template. I did not know not know that conan newcould use templates. Can we put a link in a doc to your template repo? Can these templates be put in CCI?

@ericLemanissier ericLemanissier marked this pull request as draft March 22, 2022 10:52
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent initiative!

docs/package/all/conanfile.py Outdated Show resolved Hide resolved
docs/package/all/conanfile.py Outdated Show resolved Hide resolved
docs/package/all/conanfile.py Show resolved Hide resolved
docs/package/all/conanfile.py Outdated Show resolved Hide resolved
@SSE4
Copy link
Contributor

SSE4 commented Mar 28, 2022

I'll do a pr on your repo then. It's more usable as a proper template. I did not know not know that conan newcould use templates. Can we put a link in a doc to your template repo? Can these templates be put in CCI?

yes, why not. I have been thinking how to properly organize that, but probably forgot about it at some point in time.

@ericLemanissier ericLemanissier dismissed stale reviews from SSE4 and intelligide via f958791 April 4, 2022 08:16
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

docs/package/all/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to move this forward! At least this seems like a good starting point

@ericLemanissier ericLemanissier marked this pull request as ready for review May 16, 2022 04:47
@conan-center-bot
Copy link
Collaborator

Updating docs!

@conan-center-bot conan-center-bot merged commit 4614c56 into conan-io:master May 16, 2022
@ericLemanissier ericLemanissier deleted the recipe_template branch May 16, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants