Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: fixed stacktrace_windbg* components, improved stacktrace test. #7281

Merged

Conversation

eigenwhat
Copy link
Contributor

Specify library name and version: boost/1.77.0

The proper component is stacktrace_windbg (or stacktrace_windbg_cached) but when setting extra component info it was misspelled stacktrace_windb/stacktrace_windb_cached, leaving the aforementioned components unusably broken.

The stacktrace test only checked for spurious defines that shouldn't be there ("if X is defined, I should be testing X"). It never checked for the ones which ought to be defined ("if I am testing X, X should be defined"), meaning if nothing was defined at all (as was the case before this patch), it would happily pass. I added a complementary set of checks to cover that.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

self.cpp_info.components["stacktrace_windb"].system_libs.extend(["ole32", "dbgeng"])
self.cpp_info.components["stacktrace_windb_cached"].defines.append("BOOST_STACKTRACE_USE_WINDBG_CACHED")
self.cpp_info.components["stacktrace_windb_cached"].system_libs.extend(["ole32", "dbgeng"])
self.cpp_info.components["stacktrace_windbg"].defines.append("BOOST_STACKTRACE_USE_WINDBG")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@SSE4 SSE4 reopened this Sep 14, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 2 (2212f4c8a80b1621ea5c80059e73feeacef0e2a6):

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit e3b90ff into conan-io:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants