-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: fixed stacktrace_windbg* components, improved stacktrace test. #7281
boost: fixed stacktrace_windbg* components, improved stacktrace test. #7281
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
self.cpp_info.components["stacktrace_windb"].system_libs.extend(["ole32", "dbgeng"]) | ||
self.cpp_info.components["stacktrace_windb_cached"].defines.append("BOOST_STACKTRACE_USE_WINDBG_CACHED") | ||
self.cpp_info.components["stacktrace_windb_cached"].system_libs.extend(["ole32", "dbgeng"]) | ||
self.cpp_info.components["stacktrace_windbg"].defines.append("BOOST_STACKTRACE_USE_WINDBG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
All green in build 2 (
|
Specify library name and version: boost/1.77.0
The proper component is
stacktrace_windbg
(orstacktrace_windbg_cached
) but when setting extra component info it was misspelledstacktrace_windb
/stacktrace_windb_cached
, leaving the aforementioned components unusably broken.The stacktrace test only checked for spurious defines that shouldn't be there ("if X is defined, I should be testing X"). It never checked for the ones which ought to be defined ("if I am testing X, X should be defined"), meaning if nothing was defined at all (as was the case before this patch), it would happily pass. I added a complementary set of checks to cover that.
conan-center hook activated.