Fix Folly to build with current VS version

[dmn-star]

Specify library name and version: folly/2019.10.21.00

Fixes #3983

Relates to facebook/folly#1412

Fix Folly to build on Linux

Relates to facebook/folly#1414

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying folly/all recipe:

• [folly] fix lib link order + use validate + bump deps + add elf #3711
• folly: bump libunwind version to 1.5.0 #3675
• folly: enable folly MSVC (static) #3177

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[conan-center-bot]

An unexpected error happened and has been reported. Help is on its way! 🏇

[conan-center-bot]

All green in build 2 (f4a7bc4ee2eca3bc1c7076a2dfb74a04aa732af5)! 😊

• folly/2019.10.21.00: Generated 82 packages. All logs here
• folly/2020.08.10.00: Generated 62 packages. All logs here

[conan-center-bot]

All green in build 3 (f4a7bc4ee2eca3bc1c7076a2dfb74a04aa732af5)! 😊

• folly/2019.10.21.00: Generated 82 packages. All logs here
• folly/2020.08.10.00: Generated 62 packages. All logs here

[conan-center-bot]

An unexpected error happened and has been reported. Help is on its way! 🏇

[conan-center-bot]

Some configurations of 'folly/2019.10.21.00' failed in build 5 (220de6538abf1c6d6e6063bcb7935c5c74b48840):

• Linux x86_64, Debug, gcc 9, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 8, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 8, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 8, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 8, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 7, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 9, libstdc++11 . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 9, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 6, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 9, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 8, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 9, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 6, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 7.0, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 7, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 7.0, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 7.0, libc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 8, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 8, libc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 9, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 6.0, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 5, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 6, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 8, libc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, clang 7.0, libc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 8, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 9, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 7, libstdc++11 . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 7, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 7, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 5, libstdc++11 . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 6, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 5, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 5, libstdc++11 . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 6, libstdc++ . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Release, gcc 6, libstdc++11 . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, gcc 6, libstdc++11 . Options: folly:shared-True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 9, libc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Linux x86_64, Debug, clang 9, libstdc++ . Options: folly:shared-False
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[dmn-star]

Now I am not sure which is better: "unexpected error" or failed. 😂
Do you have updated the CI to use the new CMake version?

https://github.com/facebook/folly/blob/master/CMake/GenPkgConfig.cmake

  # Since CMake 3.18 FindThreads may include a generator expression requiring
  # a target, which gets propagated to us through INTERFACE_COMPILE_OPTIONS.
  # Before CMake 3.19 there's no way to solve this in a general way, so we
  # work around the specific case. See #1414 and CMake bug #21074.
  if(CMAKE_VERSION VERSION_LESS 3.19)
    string(REPLACE
      "<COMPILE_LANG_AND_ID:CUDA,NVIDIA>" "<COMPILE_LANGUAGE:CUDA>"
      cflags "${cflags}"
    )
  endif()

Error log

CMake Error at source_subfolder/CMakeLists.txt:417 (file):
Error evaluating generator expression:

$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>

$<COMPILE_LANG_AND_ID:lang,id> may only be used with binary targets to
specify include directories, compile definitions, and compile options. It
may not be used with the add_custom_command, add_custom_target, or
file(GENERATE) commands.

CMake Error at source_subfolder/CMakeLists.txt:417 (file):
Error evaluating generator expression:

$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>

$<COMPILE_LANG_AND_ID:lang,id> may only be used with binary targets to
specify include directories, compile definitions, and compile options. It
may not be used with the add_custom_command, add_custom_target, or
file(GENERATE) commands.

[dmn-star]

Failed again but why? 🤨

[prince-chrismc]

Probably not enough build agents

[dmn-star]

Ok. I give Facebook one last chance. 😂

[conan-center-bot]

All green in build 10 (e679ee7e56fac049730cd5c18898326b53dea158)! 😊

• folly/2019.10.21.00: Generated 82 packages. All logs here
• folly/2020.08.10.00: Generated 62 packages. All logs here

[dmn-star]

Now we have to be quick before any new build tools update break the old folly again. Please review.

[conan-center-bot]

All green in build 11 (e679ee7e56fac049730cd5c18898326b53dea158)! 😊

• folly/2019.10.21.00: Generated 82 packages. All logs here
• folly/2020.08.10.00: Generated 62 packages. All logs here

[prince-chrismc]

We need to merge this so I can fix my PR too

[dmn-star]

as often we need more reviewers. :-)

[dmn-star]

@Croydon @uilianries @danimtb

Any idea why the build failed again without any response message?

[uilianries]

@dmn-star It occurred an internal timeout while building Folly. As you know, it requires more time than other projects to be built. Let's try again.

[conan-center-bot]

All green in build 13 (c483c50887c231cabd2061f0218ad5f3e59414e4)! 😊

• folly/2019.10.21.00: Generated 82 packages. All logs here
• folly/2020.08.10.00: Generated 62 packages. All logs here

[dmn-star]

We need to merge this so I can fix my PR too

May be today 😂

#2857