xz_utils: patch in build() instead of source() + remove msys2 dependency if Visual Studio + split build and install #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green in build 1 (
|
madebr
approved these changes
Oct 16, 2020
| return self._autotools | ||
| self._autotools = AutoToolsBuildEnvironment(self, win_bash=tools.os_info.is_windows) | ||
| args = ["--disable-doc"] | ||
| if self.settings.os != "Windows" and self.options.get_safe("fPIC", True): |
There was a problem hiding this comment.
since fPIC is deleted on windows is This flag enables so we need to limit that there's no else my mistakeget_safe no enough?
prince-chrismc
approved these changes
Oct 18, 2020
SSE4
approved these changes
Oct 19, 2020
|
3 approvals but no merge 🤔 in 7hrs... is that expected? |
|
@danimtb Nevermind, this fixed itself. |
|
@madebr I see a lot of PRs are "late" being merged... I think Space opened too many the it's just struggling to keep up 🤣 from my emails I got four other (I've reviewed) but the CCI bot is slowly catching up. |
|
Indeed. the cloud acts in mysterious ways 🤣 |
|
The bot merges one PR every 30 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: xz_utils/all
conan-center hook activated.