Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add android-ndk r21d #3004
add android-ndk r21d #3004
Changes from all commits
7b086cb
435c295
f78f67f
5b71707
ba854f4
6d6d84a
202c0b2
6ca6f9e
d17a61d
12bca4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this package have a
toolchain
method?See https://docs.conan.io/en/latest/creating_packages/toolchains/cmake.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs further investigation since I never used that methode, but a good point!
also, there is actually a toolchain file included in, /build/cmake/android.toolchain.cmake
need to check if this could simplify the cmake wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also interested in knowing if this package will be compatible with the new
toolchain
features.For instance here https://docs.conan.io/en/latest/integrations/cross_platform/android.html#use-built-in-conan-toolchain they use a profile:host with
android_ndk_installer/r20@bincrafters/stable
and conan_toolchain.cmake gets filled with all the information.Is the current package a drop-in replacement for the bincrafters recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hopobcn , this NDK package makes much more, it allows also building packages that do not use CMake, like openssl or curl
Why creating an own toolchain if you can get one from the NDK, that is for sure the most complete one?
If you create your toolchain file, it should just include that one from the NDK anyway
It is not a drop in replacement, because it works with the (not so) new 2 profile approach, the bincrafter one used the one profile way with os_buid and os_arch
The future is the 2 profile way.