-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add proposal/7.5.1 and update recipe for conan2 #16851
Conversation
This comment has been minimized.
This comment has been minimized.
…dex into proposal_conan2
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a509496proposal/7.5.0
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 59e717eproposal/7.4.0
proposal/7.4.1
proposal/7.4.2
proposal/7.0.7
proposal/7.1.0
proposal/7.3.0
proposal/7.5.1
proposal/7.2.1
proposal/7.0.2
proposal/7.0.4
proposal/7.3.1
proposal/7.1.1
proposal/7.0.5
proposal/7.5.0
|
The conan v2 pipeline fails because the cubicinterpolation package has not yet been updated for conan v2. I have already created a PR for this (#16299), but unfortunately this hasn't been reviewed yet. |
This comment has been minimized.
This comment has been minimized.
|
||
class TestPackageConan(ConanFile): | ||
settings = "os", "arch", "compiler", "build_type" | ||
generators = "cmake", "cmake_find_package_multi" | ||
generators = "CMakeToolchain", "CMakeDeps", "VirtualRunEnv" | ||
requires = "spdlog/1.9.2" # TODO: not sure why this is explicitly necessary, but it fails without it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conan 2.0 changes the graph model and deps are private by default to encourage good software practices.
you need to add a transitive_header=True
with a link to the reason why it's need (ie a comment from the bot failing is perfect or a link to the source code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am honestly note sure why I would need to put transitive_headers=True
for spdlog, but not for any other libraries.
If I don't (and do not explicitly write requires = "spdlog/1.9.2"
in the conanfile of the test_package), I get the error
/usr/local/include/spdlog/fmt/fmt.h:27:14: fatal error: fmt/core.h: No such file or directory
27 | # include <fmt/core.h>
which sounds related to the experience in #11981 and #15832...
I could do this, and this does fix the issue, but I would like to understand why this is necessary 😅
@@ -0,0 +1,21 @@ | |||
#include "PROPOSAL/PROPOSAL.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be delete with the improved CMakeLists.txt template :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments are your other PR, pretty easy ones
you need to change https://github.com/conan-io/conan-center-index/pull/16851/files#diff-f43c124420645bac1f2bb5eaa326a41c40865fc54f9f2b43420d3100b21335ffR49 to use rm_safe
too pretty please
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c00a2caproposal/7.2.1
proposal/7.0.5
proposal/7.5.1
proposal/7.4.2
proposal/7.0.4
proposal/7.0.2
proposal/7.5.0
proposal/7.3.1
proposal/7.4.0
proposal/7.3.0
proposal/7.1.0
proposal/7.4.1
proposal/7.1.1
proposal/7.0.7
|
Hooks produced the following warnings for commit d89467dproposal/7.5.1
proposal/7.4.1
proposal/7.3.1
proposal/7.4.0
proposal/7.0.4
proposal/7.4.2
proposal/7.1.1
proposal/7.5.0
proposal/7.0.2
proposal/7.1.0
proposal/7.3.0
proposal/7.0.7
proposal/7.2.1
proposal/7.0.5
|
I've been trying to reproduce the issue with the conan v2 pipeline locally, but was unsuccessful so far...
and if it is actually a problem, it might be related to #5188. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 565ac38proposal/7.0.2
proposal/7.0.7
proposal/7.0.4
proposal/7.2.1
proposal/7.3.0
proposal/7.1.1
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6704c1aproposal/7.5.1
proposal/7.4.1
proposal/7.4.2
proposal/7.3.1
proposal/7.1.1
proposal/7.0.5
proposal/7.1.0
proposal/7.0.4
proposal/7.0.2
proposal/7.5.0
proposal/7.2.1
proposal/7.3.0
proposal/7.4.0
proposal/7.0.7
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit b1155baproposal/7.4.0
proposal/7.5.1
proposal/7.5.0
proposal/7.4.2
proposal/7.4.1
proposal/7.3.0
proposal/7.3.1
proposal/7.2.1
proposal/7.1.1
proposal/7.0.2
proposal/7.0.7
proposal/7.0.5
proposal/7.1.0
proposal/7.0.4
|
Hi @Jean1995, thank you for your contribution. I have reviewed the use of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this recipe to support Conan 2.0, and for re-ordering the versions in the yaml file! :)
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9218ba0proposal/7.3.0
proposal/7.5.1
proposal/7.4.0
proposal/7.4.2
proposal/7.0.5
|
Conan v1 pipeline ✔️All green in build 16 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 15 (
|
Hooks produced the following warnings for commit f8ba957proposal/7.5.0
proposal/7.4.1
proposal/7.3.1
proposal/7.0.5
proposal/7.1.0
proposal/7.0.2
proposal/7.2.1
proposal/7.0.4
proposal/7.0.7
proposal/7.1.1
|
@@ -57,48 +62,45 @@ def _minimum_compilers_version(self): | |||
return {"Visual Studio": "15", "gcc": "5", "clang": "5", "apple-clang": "5"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add "msvc": "191"
to this dictionary
@property | ||
def _source_subfolder(self): | ||
return "source_subfolder" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a layout is missing, and this attribute could be removed
|
||
required_conan_version = ">=1.43.0" | ||
required_conan_version = ">=1.53.0" | ||
|
||
|
||
class PROPOSALConan(ConanFile): | ||
name = "proposal" | ||
homepage = "https://github.com/tudo-astroparticlephysics/PROPOSAL" | ||
license = "LGPL-3.0" | ||
exports_sources = "CMakeLists.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is not required anymore
I've opened #17031 |
Specify library name and version: proposal/7.5.1
This recipe add version 7.5.1, and I have tried my best to modernize the package to be compatible with conan2 (while still remaining compatible with conan 1.x for now).
I'm open for feedback 🙂 We have users that would like to use the newest version of proposal, so I would be very glad if someone could find the time to review my PR.