jsoncons recipe #16256
jsoncons recipe #16256
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Overall this looks really good, there's a few small mistakes, you can use the template to help fix them https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/header_only/all/conanfile.py :)
good work so far
recipes/jsoncons/all/conanfile.py
Outdated
| homepage = "https://github.com/danielaparker/jsoncons" | ||
| url = "https://github.com/danielaparker/jsoncons" |
There was a problem hiding this comment.
Please run this locally with the hooks enabled 🙏
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hey @prince-chrismc ! |
|
prince-chrismc/conan-center-index-pending-review#1 You can see the graphs theres quiet a hefty backlog of PRs and we are working our way through them :) |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 8 (
|
| self.cpp_info.set_property("cmake_file_name", "jsoncons") | ||
| self.cpp_info.set_property("cmake_target_name", "jsoncons") | ||
|
|
||
| # TODO: to remove in conan v2 once cmake_find_package* generators removed | ||
| self.cpp_info.names["cmake_find_package"] = "jsoncons" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "jsoncons" |
There was a problem hiding this comment.
cmake_find_package and cmake_find_package_multi are obviously broken here, no one noticed that?
There was a problem hiding this comment.
They shouldnt be used anyways :) Wasnt a blocker in my head
* jsoncons * Fixed imports * layout src_folder=src * Fixed get * Fixed build and other improvements * Added settings * More fixes
Specify library name and version: jsoncons/0.169.0
Adding Conan support to jsoncons. Agreed with the owner of the library in this issue.