Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxml2: bump dependencies + use NMakeToolchain/NMakeDeps for msvc build #16169

Merged
merged 5 commits into from
Mar 21, 2023
Merged

libxml2: bump dependencies + use NMakeToolchain/NMakeDeps for msvc build #16169

merged 5 commits into from
Mar 21, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 20, 2023

Specify library name and version: lib/1.0

@SpaceIm
bump xz_utils
891f632
@SpaceIm
modernize more
f9ef5de 
- use NMakeToolchain & NMakeDeps for msvc build
- check `tools.gnu:pkg_config`
- use fix_apple_shared_install_name() instead of patching upstream configure file
jwillikers
jwillikers previously approved these changes Feb 20, 2023
View reviewed changes
@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/libxml2//'.

👋 @Hopobcn you might be interested. 😉

@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Mar 8, 2023
@SpaceIm SpaceIm reopened this Mar 8, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Mar 8, 2023

also fix check of CMake variables (see #16389 (comment))

@SpaceIm SpaceIm closed this Mar 8, 2023
@SpaceIm SpaceIm reopened this Mar 8, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Mar 9, 2023
@SpaceIm SpaceIm reopened this Mar 9, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (bec566e49b86807b73bb6d480fceb57903b3e555):

  • libxml2/2.10.3@:
    All packages built successfully! (All logs)

  • libxml2/2.9.12@:
    All packages built successfully! (All logs)

  • libxml2/2.9.13@:
    All packages built successfully! (All logs)

  • libxml2/2.9.10@:
    All packages built successfully! (All logs)

  • libxml2/2.9.9@:
    All packages built successfully! (All logs)

  • libxml2/2.9.14@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 8 (bec566e49b86807b73bb6d480fceb57903b3e555):

  • libxml2/2.10.3@:
    All packages built successfully! (All logs)

  • libxml2/2.9.14@:
    All packages built successfully! (All logs)

  • libxml2/2.9.13@:
    All packages built successfully! (All logs)

  • libxml2/2.9.12@:
    All packages built successfully! (All logs)

  • libxml2/2.9.9@:
    All packages built successfully! (All logs)

  • libxml2/2.9.10@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4e2e492 into conan-io:master Mar 21, 2023
@SpaceIm SpaceIm deleted the libxml2-modernize-more branch March 21, 2023 00:27
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Mar 27, 2023
@SpaceIm @AbrilRBS
(conan-io#16169) libxml2: bump dependencies + use NMakeToolchain/NMak…
a960a1f 
…eDeps for msvc build

* bump xz_utils

* modernize more

- use NMakeToolchain & NMakeDeps for msvc build
- check `tools.gnu:pkg_config`
- use fix_apple_shared_install_name() instead of patching upstream configure file

* fix test of custom CMake variables

* more robust definition of custom CMake variables

* improve LIBXML2_VERSION_STRING
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
@SpaceIm @0xFireWolf
(conan-io#16169) libxml2: bump dependencies + use NMakeToolchain/NMak…
877e812 
…eDeps for msvc build

* bump xz_utils

* modernize more

- use NMakeToolchain & NMakeDeps for msvc build
- check `tools.gnu:pkg_config`
- use fix_apple_shared_install_name() instead of patching upstream configure file

* fix test of custom CMake variables

* more robust definition of custom CMake variables

* improve LIBXML2_VERSION_STRING
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @prince-chrismc @jwillikers