simplify MPI #4
Merged
simplify MPI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should start simple, assuming an environment has one MPI implementation and version. I also do not like hardcoding specific library names into the labels themselves. With this tweak we will define a main MPI implementation and version, and we can expand upon that if/when it is absolutely needed. Likely a set of labels that are very library/software specific also need to belong to a package manager and not the generic set that we have here. Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should start simple, assuming an environment has one MPI implementation and version. I also do not like hardcoding specific library names into the labels themselves. With this tweak we will define a main MPI implementation and version, and we can expand upon that if/when it is absolutely needed. Likely a set of labels that are very library/software specific also need to belong to a package manager and not the generic set that we have here.