Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prefetch images in help modal for smoother image display #22

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

yiukuenchu
Copy link
Contributor

@yiukuenchu yiukuenchu commented Oct 31, 2024

Description

To avoid images loading in the HelpModal page.

Changes Made

  • Add a prefecthImages() util
  • Use it in the HelpModal page

Related Issues

Fixes #21

Additional Notes

No

src/components/HelpModal.tsx Outdated Show resolved Hide resolved
@jsun969 jsun969 merged commit 2decdb4 into compsci-adl:main Oct 31, 2024
0 of 2 checks passed
@yiukuenchu
Copy link
Contributor Author

I reverted the yml/yaml format support and restored lint script in this PR, as I think it is better practice to put those in another PR because they don't relate directly to #21 . @jsun969 @phoenixpereira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] How-To Images Take a While to Load
3 participants