Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: make elastic service startup optional #35

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Refactor: make elastic service startup optional #35

merged 2 commits into from
Dec 9, 2024

Conversation

thekaveman
Copy link
Member

Closes #34

@thekaveman
feat(compose): add profile for elasticstack services
f24755f 
services with a profile aren't started unless the profile
is activated

environment variable COMPOSE_PROFILES can be used
to activate profiles
@thekaveman
feat(devcontainer): remove explicit service start
35149c8 
now relying on profiles to determine which services start
@thekaveman thekaveman requested a review from a team as a code owner December 6, 2024 22:48
@thekaveman thekaveman added this to the Elastic Stack setup milestone Dec 6, 2024
lalver1
lalver1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is really useful, it works great!

@thekaveman thekaveman merged commit b124410 into main Dec 9, 2024
2 checks passed
@thekaveman thekaveman deleted the refactor/optional-elastic branch December 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalver1 lalver1 lalver1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Elastic Stack setup
Development

Successfully merging this pull request may close these issues.

Make elastic service startup optional
2 participants
@thekaveman @lalver1