Move classpath modifiers to before creating classloader, change README

README.md

@@ -9,7 +9,7 @@ Jumploader is a mod that allows the use of Fabric mods in Twitch modpacks, by lo
 
 ## What it doesn't do
 - Jumploader doesn't let you run Fabric mods in tandem with Forge mods - it hijacks the launching process so that Forge never loads. See [Patchwork](https://github.com/PatchworkMC) for a project aiming to do this.
-- Jumploader doesn't currently work very well on the client for loading a Minecraft game with a different major version (including snapshots) to the currently loaded game, as supplementary assets (such as sounds) are downloaded separately by the game launcher.
+- Jumploader doesn't currently work very well on the client for loading a Minecraft game with a different major version (including snapshots) to the currently loaded game, as supplementary assets (such as sounds) are downloaded separately by the game launcher. It may be possible, however, to make a Fabric mod that fixes this issue.
 
 ## Requirements
 Requires a Forge version that uses ModLauncher (or ModLauncher on it's own, without Forge) - this usually means 1.13 or newer.

src/main/java/link/infra/jumploader/Jumploader.java

@@ -116,6 +116,13 @@ public void onLoad(@Nonnull IEnvironment env, @Nonnull Set<String> set) {
 		SpecialCaseHandler specialCaseHandler = new SpecialCaseHandler();
 		specialCaseHandler.filterAppliedCases(loadUrls, config.launch.mainClass, argsParsed);
 
+		// Apply the classpath modifiers
+		for (ClasspathModifier modifier : specialCaseHandler.getImplementingCases(ClasspathModifier.class)) {
+			if (modifier.shouldApply(loadUrls, config.launch.mainClass, argsParsed)) {
+				modifier.modifyClasspath();
+			}
+		}
+
 		// Create the classloader with the found JARs
 		URLClassLoader newLoader = new JumploaderClassLoader(loadUrls.toArray(new URL[0]), specialCaseHandler);
 		Thread.currentThread().setContextClassLoader(newLoader);
@@ -134,13 +141,6 @@ public void onLoad(@Nonnull IEnvironment env, @Nonnull Set<String> set) {
 			}
 		}
 
-		// Apply the classpath modifiers
-		for (ClasspathModifier modifier : specialCaseHandler.getImplementingCases(ClasspathModifier.class)) {
-			if (modifier.shouldApply(loadUrls, config.launch.mainClass, argsParsed)) {
-				modifier.modifyClasspath();
-			}
-		}
-
 		int preLaunchRunningThreads = Thread.currentThread().getThreadGroup().activeCount();
 
 		LOGGER.info("Jumping to new loader, main class: " + config.launch.mainClass);