Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not all all done.
Using DiffVector we can aggregate
SUM
andCOUNT
in a more efficient, "parallel" way.The idea is to port all of them.
Currently not working is the correct rearrangement of input variables and output variables.
We can use Differentials Monoids to track different aggregates in the Diff.
We
explode()
the value vector into a DiffVector and maintain the monoid corresponding to the given aggregation. Usingcount
we resurface the values into the data part.A few minor caveats:
Diff
<- Doesn't look to nice thoughAVG
orVAR
requirers some post processing currently not there.