-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat code splitting #234
Open
hasahmad
wants to merge
8
commits into
master
Choose a base branch
from
feat-code-splitting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat code splitting #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- split each folder with index.ts in styles/ dir to it's own package - existing code should move components to their own directories like Input as many components in a file - new components should be created in their own directories - add eslint for fix lint errors in rollup js files - update and optimize rollup build
…eat-code-splitting
… feat-code-splitting
Code splitting... for testing purpose you can pull
For separate components like Select
|
hasahmad
requested review from
xiaohanzhang,
robert-commonsku,
alexandra-commonsku,
kelvin-commonsku and
andy-commonsku
February 1, 2024 21:12
still work in progress, but should be good for testing right now |
alexandra-commonsku
previously approved these changes
Feb 5, 2024
hasahmad
dismissed
alexandra-commonsku’s stale review
February 26, 2024 17:37
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.