Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat code splitting #234

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Feat code splitting #234

wants to merge 8 commits into from

Conversation

hasahmad
Copy link
Collaborator

@hasahmad hasahmad commented Feb 1, 2024

No description provided.

Haseeb Ahmad added 3 commits February 1, 2024 11:42
- split each folder with index.ts in styles/ dir to it's own package
- existing code should move components to their own directories like Input as many components in a file
- new components should be created in their own directories
- add eslint for fix lint errors in rollup js files
- update and optimize rollup build
@hasahmad hasahmad changed the base branch from master to CORE-445 February 1, 2024 20:49
@hasahmad
Copy link
Collaborator Author

hasahmad commented Feb 1, 2024

Code splitting...
This separates folders in styles directory if the folder contains index.ts file.
Example: it will create a separate package for Select component which is in a separate directory in styles folder.

for testing purpose you can pull

  • package this with npm run prepack && npm pack
  • then install in the main app npm install commonsku-styles-1.17.25.tgz
  • then use the Select component like this import { Select } from '@commonsku/styles/dist/Select'

For separate components like Select

  • you can pack the select component using cd dist/ && tar -cvzf Select.tgz Select && mv Select.tgz ../ && cd ../
  • then install using npm install Select.tgz
  • then import and use the component using import { Select } from '@commonsku/styles-select'

@hasahmad
Copy link
Collaborator Author

hasahmad commented Feb 1, 2024

still work in progress, but should be good for testing right now

Base automatically changed from CORE-445 to master February 26, 2024 17:37
@hasahmad hasahmad dismissed alexandra-commonsku’s stale review February 26, 2024 17:37

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants