Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3x - boolean schemas #287

Merged
merged 1 commit into from
Oct 31, 2024
Merged

v3x - boolean schemas #287

merged 1 commit into from
Oct 31, 2024

Conversation

commonism
Copy link
Owner

as defined in
https://json-schema.org/draft/2020-12/json-schema-core#section-4.3.2

true: {}
false: {not: {}}

previously boolean schemas were restricted to additionalProperties and there was inconsistent support for the expanded version of boolean schemas

c.f. - swagger-api/swagger-parser#1770

as defined in
https://json-schema.org/draft/2020-12/json-schema-core#section-4.3.2

true: {}
false: {not: {}}

previously boolean schemas were restricted to additionalProperties and there was inconsistent support for the expanded version of boolean schemas
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.21%. Comparing base (72cedc9) to head (e8bfe04).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
aiopenapi3/model.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   94.25%   94.21%   -0.04%     
==========================================
  Files          86       86              
  Lines        7235     7277      +42     
==========================================
+ Hits         6819     6856      +37     
- Misses        416      421       +5     
Flag Coverage Δ
core 94.21% <96.61%> (-0.04%) ⬇️
tests 94.21% <96.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@commonism commonism merged commit 2aab9ab into master Oct 31, 2024
14 of 15 checks passed
@commonism commonism deleted the boolean branch October 31, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant