Handle spurious ReceiveScatterOutput callbacks
#2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #2003 by handling spurious, repeated callbacks of the `receive_scatter_output` method of the `ReceiveScatterOutput` class. The reason of multiple awakenings has not been investigated deeply, though. In the future, a thorough examination of the `MultithreadedJobExecutor` logic may be necessary.
mr-c
requested changes
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2051 +/- ##
==========================================
+ Coverage 83.56% 83.88% +0.32%
==========================================
Files 46 46
Lines 8270 8274 +4
Branches 2202 2204 +2
==========================================
+ Hits 6911 6941 +30
+ Misses 872 857 -15
+ Partials 487 476 -11 ☔ View full report in Codecov by Sentry. |
Fixed `_completed` attribute type Co-authored-by: Michael R. Crusoe <[email protected]>
mr-c
approved these changes
Oct 8, 2024
|
Thank you @GlassOfWhiskey ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #2003 by handling spurious, repeated callbacks of the
receive_scatter_outputmethod of theReceiveScatterOutputclass. The reason of multiple awakenings has not been investigated deeply, though. In the future, a thorough examination of theMultithreadedJobExecutorlogic may be necessary.