Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring #6411

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Conversation

theobat
Copy link
Contributor

@theobat theobat commented Jan 13, 2024

Many things arre happening in the Execute Module, which requires a big split, like prior work, we'll have execute, executePackage, executeComponent

@mpilgrem
Copy link
Member

@theobat, my plan is [1] to merge a couple of field namings that I have in progress, then [2] rebase this pull request against the master branch and merge it, then [3] continue with other field namings.

@theobat
Copy link
Contributor Author

theobat commented Jan 13, 2024

ok @mpilgrem I just rebased, but feel free to add some more renamings

@mpilgrem mpilgrem merged commit 635e709 into commercialhaskell:master Jan 13, 2024
12 of 13 checks passed
@mpilgrem
Copy link
Member

mpilgrem commented Jan 14, 2024

@theobat, after I merged this, I realised that it has code duplicated in Stack.Build.Execute and Stack.Build.ExecuteEnv. For example, both define and export withSingleContext. Was that the intention?

EDIT: I think I've worked out what was intended see #6420

mpilgrem added a commit that referenced this pull request Jan 14, 2024
mpilgrem added a commit that referenced this pull request Jan 14, 2024
@theobat
Copy link
Contributor Author

theobat commented Jan 14, 2024

@mpilgrem no the datatypes and functions exported by ExecuteEnv should only be imported in Execute and not be redefined (the code is the same, it's only a module breakup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants