Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket subscriptions #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ChronosXYZ
Copy link

Problem

Websocket event subscription doesn't work. Events are not received through the subscription sink though they are received by the websocket driver.

Solution

This PR ports fix for subscription router from informalsystems/tendermint-rs#1433. Also I found deserialization error when we try to parse received event, because CometBFT node sends null in data.results_finalize_block.validator_updates field instead of empty array. I fixed that by using a custom deserialization function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant